Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add user and privilege proto definition #2645

Merged
merged 8 commits into from
May 19, 2022
Merged

feat: add user and privilege proto definition #2645

merged 8 commits into from
May 19, 2022

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented May 18, 2022 •
edited
Loading

What's changed and what's your intention?

As title, according to #2643

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Part of #2193

@yezizp2012 yezizp2012 marked this pull request as draft May 18, 2022 10:53
@codecov
Copy link

codecov bot commented May 18, 2022 •
edited
Loading

Codecov Report

Merging #2645 (2dd8ffa) into main (f2c003f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2645   +/-   ##
=======================================
  Coverage   72.19%   72.19%           
=======================================
  Files         681      681           
  Lines       88477    88494   +17     
=======================================
+ Hits        63872    63888   +16     
- Misses      24605    24606    +1
Flag Coverage Δ
rust 72.19% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/prost/src/lib.rs 96.29% <ø> (ø)
src/utils/pgwire/src/pg_protocol.rs 0.00% <0.00%> (ø)
src/risedevtool/src/config_gen/grafana_gen.rs 0.00% <0.00%> (ø)
src/utils/pgwire/src/pg_message.rs 8.08% <0.00%> (+8.08%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@neverchanje
Copy link
Contributor

Do we have a plan for what SQL we want to support specifically? There are several options in Postgres's CREATE USER command, https://www.postgresql.org/docs/current/sql-createuser.html. I think we need a priority and focus on delivering a minimized feature set. I don't know what is required in the initial stage.

@yezizp2012
Copy link
Member Author

yezizp2012 commented May 19, 2022 •
edited
Loading

Do we have a plan for what SQL we want to support specifically? There are several options in Postgres's CREATE USER command, https://www.postgresql.org/docs/current/sql-createuser.html. I think we need a priority and focus on delivering a minimized feature set. I don't know what is required in the initial stage.

Please visit #2643 for more details. I list all syntaxes we plan to support in current stage.

@yezizp2012 yezizp2012 marked this pull request as ready for review May 19, 2022 06:19
TennyZhuang
TennyZhuang reviewed May 19, 2022
View reviewed changes
proto/user.proto Outdated Show resolved Hide resolved
@yezizp2012 yezizp2012 enabled auto-merge (squash) May 19, 2022 07:55
@yezizp2012 yezizp2012 merged commit e3f2fe0 into main May 19, 2022
@yezizp2012 yezizp2012 deleted the feat/user-catalog-proto branch May 19, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TennyZhuang TennyZhuang TennyZhuang left review comments

@liurenjie1024 liurenjie1024 liurenjie1024 approved these changes

@fuyufjh fuyufjh Awaiting requested review from fuyufjh

@neverchanje neverchanje Awaiting requested review from neverchanje

Assignees
No one assigned
Labels
type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yezizp2012 @neverchanje @liurenjie1024 @TennyZhuang